deploy(contracts): improves management DAO proposal readability (#516)

* deploy(contracts): fixes update proposal readability * deploy(contracts): don't try to execute update proposal * deploy(contracts): fixes address in admin-repo update in v1.3.0
aragon · Jan 3, 2024 · f48c1cb · f48c1cb
1 parent 1e6d56d
commit f48c1cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/contracts/deploy/update/to_v1.3.0/60_Admin_PluginRepo.ts b/packages/contracts/deploy/update/to_v1.3.0/60_Admin_PluginRepo.ts
@@ -37,7 +37,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     to: upgradeTX.to,
     data: upgradeTX.data,
     value: 0,
-    description: `Upgrade the "admin-repo" PluginRepo (${adminPluginRepo}) to the new implementation (${newPluginRepoImplementation})`,
+    description: `Upgrade the "admin-repo" PluginRepo (${adminPluginRepoAddress}) to the new implementation (${newPluginRepoImplementation})`,
   });
 };
 export default func;

diff --git a/packages/contracts/deploy/verification/99_conclude/01_managing_dao_proposal.ts b/packages/contracts/deploy/verification/99_conclude/01_managing_dao_proposal.ts
@@ -23,8 +23,8 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     await managingDAOMultisig.callStatic.multisigSettings();
 
   const proposalDescription = hre.managingDAOActions
-    .map(action => action.description)
-    .join('\n');
+    .map(action => `<p>${action.description}</p>`)
+    .join('');
   const cid = await uploadToIPFS(
     JSON.stringify({
       title: 'Framework Upgrade 1.3.0',
@@ -44,7 +44,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
         hre.managingDAOActions,
         0,
         true,
-        true,
+        false,
         0,
         Math.round(Date.now() / 1000) + 30 * 24 * 60 * 60 // Lets the proposal end in 30 days
       );