Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump OZ dependencies to 4.9.3 and add protocolVersion #454

Merged
merged 33 commits into from
Sep 28, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Aug 28, 2023

Description

Task: OS-656

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik changed the title Feature/os 656 oz dependency bump Bump OZ dependency to 4.9.3 Aug 28, 2023
@heueristik heueristik changed the title Bump OZ dependency to 4.9.3 Bump OZ dependency to 4.9.3 and add protocolVersion Aug 28, 2023
@heueristik heueristik changed the base branch from develop to feature/OS-669-dao-refactoring August 28, 2023 12:48
@heueristik heueristik marked this pull request as ready for review August 28, 2023 13:06
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove some protocolVersions as discussed this morning

@heueristik
Copy link
Contributor Author

Changed here: 9e8cbf9

@heueristik heueristik changed the base branch from feature/OS-669-dao-refactoring to develop August 31, 2023 13:52
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you or Could you confirm that those interfaces https://github.com/aragon/osx/blob/develop/packages/subgraph/src/utils/constants.ts#L26
didn't change?

mathewmeconry
mathewmeconry previously approved these changes Sep 1, 2023
@heueristik heueristik mentioned this pull request Sep 1, 2023
13 tasks
@heueristik
Copy link
Contributor Author

@heueristik heueristik force-pushed the feature/OS-656-oz-dependency-bump branch from d52c496 to 760174e Compare September 26, 2023 15:53
@heueristik
Copy link
Contributor Author

heueristik commented Sep 26, 2023

@mathewmeconry I improved the NatSpec for ProtocolVersion db7c925 as discussed in our previous call.

@heueristik heueristik force-pushed the feature/OS-656-oz-dependency-bump branch from 760174e to db7c925 Compare September 26, 2023 15:57
Rekard0
Rekard0 previously approved these changes Sep 27, 2023
@heueristik heueristik merged commit 1c7b8ec into develop Sep 28, 2023
11 checks passed
@heueristik heueristik deleted the feature/OS-656-oz-dependency-bump branch September 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants