Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/ OS-704 Add security contact to the readme(s) #470

Merged
merged 2 commits into from
Sep 27, 2023
Merged

chore/ OS-704 Add security contact to the readme(s) #470

merged 2 commits into from
Sep 27, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Sep 22, 2023 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-704

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@Rekard0 Rekard0 marked this pull request as ready for review September 22, 2023 14:46
heueristik
heueristik reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo that was already there before. Apart from that, LGTM

@Rekard0 @heueristik
Update packages/subgraph/README.md
f72d27f 
Co-authored-by: Michael Heuer <20623991+Michael-A-Heuer@users.noreply.github.com>
josemarinas
josemarinas approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@josemarinas josemarinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couldn't find any typo

@heueristik heueristik merged commit 56170f7 into develop Sep 27, 2023
@heueristik heueristik deleted the chore/OS-704_Add-security-contact-to-readmes branch September 27, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rekard0 @heueristik @josemarinas