Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: less restrictive solidity compiler pragmas #480

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Oct 6, 2023

Description

Although the compiler pragma is lowered from pragma solidity 0.8.17; to pragma solidity ^0.8.8;, we will still compile OSx with 0.8.17 and the legacy code generation pipeline (i.e., not with --viaIR). The change allows plugin developers to use newer compiler versions and test against all OSx contracts.

Task ID: OS-720

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik force-pushed the feature/OS-720-less-restrictiv-pragmas branch from 9d22249 to 542b552 Compare October 6, 2023 07:47
@heueristik heueristik marked this pull request as ready for review October 6, 2023 07:47
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We still have some pragmas in the developer portal locked to 0.8.21. It could be problematic because solidity v0.8.21 is using shanghai and includes PUSH0 thus these contracts won't deploy on L2s for now

@heueristik
Copy link
Contributor Author

LGTM. We still have some pragmas in the developer portal locked to 0.8.21. It could be problematic because solidity v0.8.21 is using shanghai and includes PUSH0 thus these contracts won't deploy on L2s for now

Yes, for the dev portal, I used a safe compiler version that is not affected by compiler bugs such as this one yet.

@heueristik heueristik merged commit 4accb52 into develop Oct 6, 2023
@heueristik heueristik deleted the feature/OS-720-less-restrictiv-pragmas branch October 6, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants