Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: trailing comma #489

Merged
merged 1 commit into from
Oct 25, 2023
Merged

style: trailing comma #489

merged 1 commit into from
Oct 25, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Oct 23, 2023 •
edited
Loading

Description

Apply the same code style settings as in https://github.com/aragon/osx-plugin-template-hardhat and https://github.com/aragon/osx-commons

Type of change

  • code style

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik heueristik changed the title style: no trailing commas style: no trailing comma Oct 23, 2023
@heueristik heueristik force-pushed the feature/prettier-trailing-comma branch from 6376fca to 6e3396f Compare October 23, 2023 12:05
@heueristik heueristik changed the title style: no trailing comma style: trailing comma Oct 23, 2023
@heueristik heueristik merged commit 6ea7c02 into develop Oct 25, 2023
@heueristik heueristik deleted the feature/prettier-trailing-comma branch October 25, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry Awaiting requested review from mathewmeconry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @josemarinas