fix: build and release metadata mixups

[heueristik]

Description

Task ID: OS-901 (surfaced in spike OS-899)

After merging this PR, the main branch must be merged into develop.

The inputs to createVersion in packages/contracts/src/framework/plugin/repo/PluginRepo.sol are as follows:

    function createVersion(
        uint8 _release,
        address _pluginSetup,
        bytes calldata _buildMetadata,
        bytes calldata _releaseMetadata
    ) 

(see here)

However, it was used here with the arguments being mixed up in the helpers packages/contracts/deploy/helpers.ts

export async function createVersion(
  pluginRepoContract: string,
  pluginSetupContract: string,
  releaseNumber: number,
  releaseMetadata: string,
  buildMetadata: string
): Promise<void> {
  const signers = await ethers.getSigners();

  const PluginRepo = new PluginRepo__factory(signers[0]);
  const pluginRepo = PluginRepo.attach(pluginRepoContract);

  const tx = await pluginRepo.createVersion(
    releaseNumber,
    pluginSetupContract,
    releaseMetadata, // <--- MIX UP
    buildMetadata.   // <--- MIX UP
  );

(see here)

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran all tests with success and extended them if necessary.
• I have updated the CHANGELOG.md file in the root folder.
• I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
• I have updated the UPDATE_CHECKLIST file in the root folder.

[heueristik]

Probably, a bit more poking and unit testing would be a good investment of our time here.