Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): replaces active_contracts.json with @aragon/osx-comons-configs #523

Merged
merged 6 commits into from
Jan 30, 2024
Merged

feat(contracts): replaces active_contracts.json with @aragon/osx-comons-configs #523

merged 6 commits into from
Jan 30, 2024

Conversation

mathewmeconry
Copy link
Contributor

@mathewmeconry mathewmeconry commented Jan 12, 2024 •
edited
Loading

Description

feat(contracts): replaces active_contracts.json with @aragon/osx-comons-configs
fix(contracts): align naming of contract during deployment with configs package
fix(contracts): renames managingDAO for deployment to managementDAO

Depends on pull aragon/osx-commons#44

Task ID: OS-930

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@mathewmeconry
feat(contracts): replaces active_contracts.json with @aragon/osx-comm…
bbede7e 
…ons-configs

fix(contracts): align naming of contract during deployment with configs package
fix(contracts): renames managingDAO for deployment to managementDAO
Rekard0
Rekard0 previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rekard0
Rekard0 previously approved these changes Jan 26, 2024
View reviewed changes
heueristik
heueristik reviewed Jan 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
heueristik
heueristik reviewed Jan 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
heueristik
heueristik reviewed Jan 29, 2024
View reviewed changes
UPDATE_CHECKLIST.md Outdated Show resolved Hide resolved
heueristik
heueristik reviewed Jan 29, 2024
View reviewed changes
UPDATE_CHECKLIST.md Outdated Show resolved Hide resolved
@mathewmeconry
chore(contracts): replaces MANAGEMENTDAO_* with MANAGEMENT_DAO_* …
1bf48ed 
…in all env variables

chore(contracts): fixes typos
@josemarinas josemarinas requested a review from Rekard0 January 30, 2024 14:12
@mathewmeconry mathewmeconry merged commit c4c0bcb into develop Jan 30, 2024
17 checks passed
@mathewmeconry mathewmeconry deleted the OS-930-remove-active-contracts-json-from-osx-repo branch January 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @Rekard0 @heueristik