Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong environment variable and contract naming in contracts test #529

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix: wrong environment variable and contract naming in contracts test #529

merged 2 commits into from
Feb 5, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Feb 5, 2024 •
edited by heueristik
Loading

Description

Rename MANAGEMENTDAO to MANAGEMENT_DAO

Task ID: OS-1009

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@heueristik
Copy link
Contributor

I've now brought my fixes into your PR

@heueristik heueristik changed the title Fix: Contracts test fix: wrong naming in contracts test Feb 5, 2024
@heueristik heueristik requested a review from Rekard0 February 5, 2024 13:42
@heueristik heueristik changed the title fix: wrong naming in contracts test fix: wrong environment variable and contract naming in contracts test Feb 5, 2024
@heueristik heueristik requested a review from jordaniza February 5, 2024 13:54
@heueristik heueristik merged commit 25a05b2 into develop Feb 5, 2024
18 checks passed
@heueristik heueristik deleted the fix/contracts-tests branch February 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@jordaniza jordaniza Awaiting requested review from jordaniza

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @heueristik @Rekard0