Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add holesky #621

Merged
merged 2 commits into from
Nov 5, 2024
Merged

add holesky #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fab6d6
add holesky
novaknole Nov 5, 2024
2808ba3
mode network
novaknole Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/contracts/deploy/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ export const ENS_ADDRESSES: {[key: string]: string} = {
mainnet: '0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e',
goerli: '0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e',
sepolia: '0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e',
holesky: '0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e',
};

export const ENS_PUBLIC_RESOLVERS: {[key: string]: string} = {
goerli: '0x19c2d5d0f035563344dbb7be5fd09c8dad62b001',
mainnet: '0x4976fb03c32e5b8cfe2b6ccb31c09ba78ebaba41',
sepolia: '0x8FADE66B79cC9f707aB26799354482EB93a5B7dD',
holesky: '0x9010A27463717360cAD99CEA8bD39b8705CCA238',
};

export const DAO_PERMISSIONS = [
Expand Down Expand Up @@ -385,5 +387,9 @@ export async function transferSubnodeChain(
}
}

export async function delay(ms: number) {
return new Promise(resolve => setTimeout(resolve, ms));
}

// hh-deploy cannot process files without default exports
export default async () => {};
6 changes: 5 additions & 1 deletion packages/contracts/deploy/new/20_permissions/99_verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {DAO__factory} from '../../../typechain';
import {checkPermission, getContractAddress} from '../../helpers';
import {checkPermission, delay, getContractAddress} from '../../helpers';
import {Operation} from '@aragon/osx-commons-sdk';
import {DeployFunction} from 'hardhat-deploy/types';
import {HardhatRuntimeEnvironment} from 'hardhat/types';
Expand All @@ -23,6 +23,10 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
deployer
);

// On some chains - such as holesky - wait so
// previous permission txs are fully applied and verified.
await delay(5000);

// Get `DAORegistryProxy` address.
const daoRegistryAddress = await getContractAddress('DAORegistryProxy', hre);

Expand Down
6 changes: 5 additions & 1 deletion packages/contracts/deploy/new/40_finalize-management-dao/99_verify_step.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {DAO__factory} from '../../../typechain';
import {checkPermission, getContractAddress} from '../../helpers';
import {checkPermission, delay, getContractAddress} from '../../helpers';
import {Operation} from '@aragon/osx-commons-sdk';
import {DeployFunction} from 'hardhat-deploy/types';
import {HardhatRuntimeEnvironment} from 'hardhat/types';
Expand Down Expand Up @@ -27,6 +27,10 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
// Get `PluginSetupProcessor` address.
const pspAddress = await getContractAddress('PluginSetupProcessor', hre);

// On some chains - such as holesky - wait so
// previous permission txs are fully applied and verified.
await delay(5000);

// Check revoked permission.
await checkPermission(managementDaoContract, {
operation: Operation.Revoke,
Expand Down
29 changes: 29 additions & 0 deletions packages/contracts/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ const config: HardhatUserConfig = {
rinkeby: process.env.ETHERSCAN_KEY || '',
goerli: process.env.ETHERSCAN_KEY || '',
sepolia: process.env.ETHERSCAN_KEY || '',
holesky: process.env.ETHERSCAN_KEY || '',
polygon: process.env.POLYGONSCAN_KEY || '',
polygonMumbai: process.env.POLYGONSCAN_KEY || '',
baseMainnet: process.env.BASESCAN_KEY || '',
Expand All @@ -111,6 +112,8 @@ const config: HardhatUserConfig = {
arbitrumOne: process.env.ARBISCAN_KEY || '',
arbitrumGoerli: process.env.ARBISCAN_KEY || '',
arbitrumSepolia: process.env.ARBISCAN_KEY || '',
modeTestnet: 'modeTestnet',
modeMainnet: 'modeMainnet',
},
customChains: [
{
Expand Down Expand Up @@ -145,6 +148,32 @@ const config: HardhatUserConfig = {
browserURL: 'https://sepolia.arbiscan.io',
},
},
{
network: 'holesky',
chainId: 17000,
urls: {
apiURL: 'https://api-holesky.etherscan.io/api',
browserURL: 'https://holesky.etherscan.io',
},
},
{
network: 'modeTestnet',
chainId: 919,
urls: {
apiURL:
'https://api.routescan.io/v2/network/testnet/evm/919/etherscan',
browserURL: 'https://testnet.modescan.io',
},
},
{
network: 'modeMainnet',
chainId: 34443,
urls: {
apiURL:
'https://api.routescan.io/v2/network/mainnet/evm/34443/etherscan',
browserURL: 'https://modescan.io',
},
},
],
},
namedAccounts: {
Expand Down
Loading