Input Masking (Meta #69) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renestalder
requested changes
Jul 23, 2024
There was a problem hiding this comment.
@marcwieland95 We need to find a way to use lazy loading on those JavaScript libraries. It's not a modern approach, creating one big chunk, and the way I understand this here, this is doing exactly that.
marcwieland95
force-pushed
the
feature/69-input-masking
branch
from
4ced969 to
59e2746
Compare
renestalder
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
@marcwieland95 Now that looks better. Wasn't able to test the solution but the code looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used with araise-dev/CrudBundle#76