This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
#32 Enabled graceful shutdown in application.properties #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arakoodev#32 Enabled graceful shutdown in appplication.properties
arakoodev#32 Updated application.properties to enable graceful shutdown
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the Arakoo CLA Document and I hereby sign the CLA |
|
recheck |
|
Hi Venkatesh
Thanks for the commits !
Are u on discord? Would love to say hello to you
…On Sun, Mar 5, 2023, 13:38 Venkatesh Vemana ***@***.***> wrote:
Reopened #39 <#39>.
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASYU24RSWHKIAOG2HNXWDW2RCW3ANCNFSM6AAAAAAVQASUVA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Hi @vemanavenkatesh137, I see that the dependency "spring-boot-starter-security" is missing. This dependency will be required by FlyFly to have a /shutdown endpoint. Can you please add these? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled graceful shutdown in application.properties
Included below properties in application.properties file
server.shutdown=graceful
spring.lifecycle.timeout-per-shutdown-phase=15s
This PR Fixes #32