Change config way i18provider #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
added a commit
that referenced
this pull request
Dec 9, 2020
* Fix plurals (#347) * Add plurals: zero, one, two, few, many, other * Update node support * Update node support * Update node support * Fix withTranslation type (#354) * Replace CLI to next plugin + move project to typescript + refactor (#359) * [WIP] Implement webpack loader * Update .gitignore * Implement loader when the _app.js has a getInitialProps * Add missing pages on example * Remove builder tests right now * Fix default loadLocaleFrom on _app.js * Implement src/_loader/hasGetInitialPropsOnAppJs.js * add I18nProvider on top of _app.js if _app.js exist * Load default app.js with I18nProvider * Remove all deprecations from 0.19 * Implement loading namespaces from getInitialProps on pages * Refactor * Refactor loader * Add tests + improve templateWithHoc * Update dependences * Implement basic template with loader * Fix case of getServerSideProps * Fix no export default * Add loadNamespaces + refactor + add snapshots * Add test cases + fix cases for getStaticProps and getServerSideProps * Add more test cases + fix more cases about global exports * Fix appWithI18n * Update .npmignore * [WIP] migrate to TypeScript * Fix loader * Apply fixes on index.js * Fix tests * add experimental version * Implement logBuild * Update package version to 1.0.0-experimental.6 * Add esModuleInterop=true * Update tsconfig.json * Add warnings * Do dynamic prop from DynamicNamespace transparent * Implement fallbacks (#333) * Add fallback typescript type (#334) * Add fallback typescript type * Update index.d.ts * Update index.d.ts * Implement default namespace on useTranslation hook (#335) * Improve type * Fix Trans type * Update dependencies * Support components trans as object (#336) * Support Trans 'components' property to be an object * Fix docs * Fix when _app.js is missing * Change way to load webpack loader * Modify todo list * Remove next/app from appWithI18n + refactor * Update docs * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update plurals docs * Add migration guide `0.x` to `1.0.0` (#349) * Add migration guide `0.x` to `1.0.0` * Fix plural section * Add yarn command * docs: add dislick as a contributor (#350) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Improve docs * Update README.md * Fix src/pages in experimiental 1.0 (#352) * Update examples + some fixes * Improve example * Improve examples * Add warning about getInitialProps on pages * add notes about appWithI18n on the migration guide * Add useful links to the migration guide * Fix imports from webpack loader in windows (#355) * Fix imports from webpack loader in windows * Fix clean helper on tests * Fix clean helper on tests * Fix comma * Fix test * Use webpack alias for absolute imports * Move plugin files to typescript * Update package version Co-authored-by: Patrick <muff.pa@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Update README with the new examples (#360) * Update README with the new examples * Add quotes * fix: compiled page pathname in windows (#362) * fix: compiled page name in windows * Update src/plugin/loader.ts Co-authored-by: Aral Roca Gomez <aral-rg@hotmail.com> Co-authored-by: Aral Roca Gomez <aral-rg@hotmail.com> * docs: add vimutti77 as a contributor (#363) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Aral Roca Gomez <aral-rg@hotmail.com> * Update package version * Change config way i18provider (#369) * Change way to use i18n config inside I18nProvider * Add default * Merge nested configs in nester I18nProviders (#370) * Fix _app.js with class extended from NextApp (#371) * Update CONTRIBUTING.md * Clean build plugin packages (#372) * Add support to customize the interpolation delimeter (#373) * Add support for nesting translations (#368) * Add support for nesting translations * Add a nested version of translations example * Add support for numbers in the nested keys * docs: add josephfarina as a contributor (#374) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Aral Roca Gomez <aral-rg@hotmail.com> * Update README.md * Update README.md * Update package version * Update README * Update README.md * Update README.md * Update example adding custom interpolation (#375) * Re-add Translate type (#376) * Improve interface Translate (#377) The interface "Translate" describes the "translate" function in three variants. In the following the variants of the return values of the function are considered. 1. the return value corresponds to a string or an object (of any complexity) - string | object In the case of an object, the return type (string | object) requires a type cast from the function's user Example 1 const translatedObject: TypeOfTranslatedObject = t( translationKey, {}, {returnObjects: true} ); example 2 const translatedObject = t( translationKey, {}, {returnObjects: true} ) as TypeOfTranslatedObject; To make the use of the function more intuitive, the object type of the object to be translated is passed to the function call as generic type parameter. Example 1 - Return of a simple object of the type TypeOfTranslatedObject const translatedObject = t<TypeOfTranslatedObject>( translationKey, {}, {returnObjects: true} ); Example 2 - Return of an array whose contents correspond to the object type TypeOfTranslatedObject const translatedObject = t<Array<TypeOfTranslatedObject>>( translationKey, {}, {returnObjects: true} ); The change made in the commit, - introduces a generic type parameter and its initialization to a string, - the type parameter is optional. If no type parameter is specified by the caller, the default value string is used. The return value of the second and third variant corresponds to a string only and no other type. The change made in the commit - removes the generic type declaration, there is only one return type, - an override from outside is not possible. Co-authored-by: gurkerl83 <markus_gritsch@gmx.de> * docs: add gurkerl83 as a contributor (#378) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Aral Roca Gomez <aral-rg@hotmail.com> * Add bundle analyzer to the complex example (#379) * Fix package (#380) * Fix package * Move types to the root * Add (getT) to get the t function outside components / pages (#383) * Support to consume t function outside React * fix typo * Fix issue with Node 10 (#386) * Update README.md * Update package version Co-authored-by: Patrick <muff.pa@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Vantroy <vimutti@outlook.com> Co-authored-by: Joey <Jrf61194@gmail.com> Co-authored-by: gurkerl83 <gurkerl83@googlemail.com> Co-authored-by: gurkerl83 <markus_gritsch@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #330
CC: @josephfarina