Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequence): add group sequence implementation #400

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

Mulavar
Copy link
Contributor

@Mulavar Mulavar commented Sep 4, 2022

What this PR does:
add group sequence implementation.

Which issue(s) this PR fixes:

ref #94

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Merging #400 (57346ec) into master (e947693) will decrease coverage by 1.41%.
The diff coverage is 5.10%.

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   39.61%   38.20%   -1.42%     
==========================================
  Files         110      118       +8     
  Lines       14738    15662     +924     
==========================================
+ Hits         5839     5983     +144     
- Misses       8183     8932     +749     
- Partials      716      747      +31     
Impacted Files Coverage Δ
pkg/sequence/group/group.go 7.96% <5.10%> (ø)
pkg/config/api.go 83.33% <0.00%> (-16.67%) ⬇️
pkg/config/file/file.go 74.26% <0.00%> (-15.21%) ⬇️
pkg/runtime/rule/shard_expr.go 78.94% <0.00%> (-9.29%) ⬇️
pkg/boot/discovery.go 57.10% <0.00%> (-8.31%) ⬇️
pkg/runtime/optimize/dml/select_scanner.go 70.63% <0.00%> (-6.38%) ⬇️
pkg/config/model.go 25.61% <0.00%> (-3.36%) ⬇️
pkg/runtime/rule/shard_expr_parse.go 82.35% <0.00%> (-3.02%) ⬇️
pkg/runtime/ast/show.go 32.99% <0.00%> (-2.92%) ⬇️
pkg/config/nacos/nacos.go 34.67% <0.00%> (-2.73%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mulavar Mulavar changed the title [WIP]feat(sequence): add group sequence implementation feat(sequence): add group sequence implementation Sep 4, 2022
@Mulavar Mulavar force-pushed the feat/group-sequence branch 5 times, most recently from 2017ce7 to c064b8a Compare September 4, 2022 09:00
@dongzl dongzl added enhancement New feature or request sharding Sharding labels Sep 4, 2022
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add ut

pkg/sequence/group/group.go Outdated Show resolved Hide resolved
pkg/sequence/group/group.go Show resolved Hide resolved
@jjeffcaii jjeffcaii merged commit c51c358 into arana-db:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sharding Sharding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants