Support MySQL CAST_TIME/CAST_DATE/CAST_DATETIME function #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 35.51% // Head: 36.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 35.51% 36.65% +1.13%
==========================================
Files 189 192 +3
Lines 21532 22042 +510
==========================================
+ Hits 7648 8079 +431
- Misses 12993 13054 +61
- Partials 891 909 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
baerwang
approved these changes
Dec 27, 2022
|
|
||
| // format - YY-MM-DD, YYYY-MM-DD | ||
| pat := "^\\d{1,4}[~!@#$%^&*_+\\-=:;,.|?/]{1}\\d{1,2}[~!@#$%^&*_+\\-=:;,.|?/]{1}\\d{1,2}$" | ||
| match, err := regexp.MatchString(pat, dateArgs) |
There was a problem hiding this comment.
Define reg as global variable
| } | ||
| // format - YYYYMMDD, YYMMDD | ||
| pat = "^\\d{5,8}$" | ||
| match, err = regexp.MatchString(pat, dateArgs) |
| } | ||
|
|
||
| pat := "^\\d{1,4}[~!@#$%^&*_+\\-=:;,|?/]{1}\\d{1,2}[~!@#$%^&*_+\\-=:;,|?/]{1}\\d{1,2}$" | ||
| match, err := regexp.MatchString(pat, datetimeArr[0]) |
| } else { | ||
| // format - YYYYMMDDhhmmss.ms | ||
| pat := "^\\d{11,14}$" | ||
| match, err := regexp.MatchString(pat, datetimeArgs) |
|
这些都不可以用标准库来处理吗？ |
求推荐~~ |
AlexStocks
approved these changes
Dec 29, 2022
|
AlexStocks
approved these changes
Jan 2, 2023
|
按周会讨论的思路重新整理下逻辑吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #570 #569 #568
Special notes for your reviewer:
Does this PR introduce a user-facing change?: