Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Support MySQL IF&IFNULL Function #588

Merged
merged 18 commits into from
Jan 10, 2023

Conversation

gongna-au
Copy link
Contributor

@gongna-au gongna-au commented Jan 1, 2023

What this PR does:

Which issue(s) this PR fixes:

Fixes #493

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Base: 35.72% // Head: 35.49% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (0e4aa9c) compared to base (d47a067).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
- Coverage   35.72%   35.49%   -0.23%     
==========================================
  Files         185      188       +3     
  Lines       21199    21491     +292     
==========================================
+ Hits         7573     7628      +55     
- Misses      12753    12979     +226     
- Partials      873      884      +11     
Impacted Files Coverage Δ
pkg/runtime/function/if.go 52.00% <52.00%> (ø)
pkg/runtime/function/if_null.go 64.70% <64.70%> (ø)
pkg/security/tenant.go 63.63% <0.00%> (-7.16%) ⬇️
pkg/runtime/ast/model.go 33.33% <0.00%> (-5.32%) ⬇️
pkg/runtime/ast/ast.go 72.66% <0.00%> (-1.11%) ⬇️
pkg/boot/discovery.go 48.03% <0.00%> (-0.89%) ⬇️
pkg/executor/redirect.go 4.08% <0.00%> (-0.85%) ⬇️
pkg/config/misc.go 0.00% <0.00%> (ø)
pkg/config/model.go 34.01% <0.00%> (ø)
pkg/mysql/server.go 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label Jan 1, 2023
@dongzl dongzl added this to the 0.2.0 milestone Jan 1, 2023
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

@dongzl dongzl changed the title [SQL] Support MySQL IF&IFNULL Function。 [SQL] Support MySQL IF&IFNULL Function Jan 5, 2023
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

@jjeffcaii jjeffcaii merged commit dc902d0 into arana-db:master Jan 10, 2023
GavinLam164 pushed a commit to GavinLam164/arana that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL] Support MySQL IF & IFNULL function.
5 participants