Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support create table SQL statement (#424) #653

Merged
merged 26 commits into from
Apr 18, 2023
Merged

Support create table SQL statement (#424) #653

merged 26 commits into from
Apr 18, 2023

Conversation

csynineyang
Copy link
Contributor

【done】1、非命中shadow rule,非命中sharding rule:穿透到0库建表;
【done】2、非命中shadow rule,命中sharding rule:建分区表;
【todo】3、命中shadow rule,非命中sharding rule:穿透到0库建影子表;
【todo】4、命中shadow rule,命中sharding rule:建影子分区表;

另外,建表语句还需完善,暂时别合入,: )

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (76c4e80) 36.90% compared to head (4d9bf3f) 36.99%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   36.90%   36.99%   +0.08%     
==========================================
  Files         203      213      +10     
  Lines       22340    23044     +704     
==========================================
+ Hits         8245     8525     +280     
- Misses      13178    13595     +417     
- Partials      917      924       +7     
Impacted Files Coverage Δ
pkg/executor/redirect.go 3.81% <0.00%> (ø)
pkg/runtime/ast/ast.go 75.04% <0.00%> (+4.20%) ⬆️
pkg/runtime/ast/create_table.go 0.00% <0.00%> (ø)
pkg/runtime/ast/proto.go 69.56% <ø> (+16.23%) ⬆️

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl changed the title Support create table SQL statement (#424) [WIP]Support create table SQL statement (#424) Mar 18, 2023
@dongzl dongzl added this to the 0.2.0 milestone Mar 18, 2023
@dongzl dongzl added the SQL SQL support label Mar 18, 2023
Copy link
Contributor

@jjeffcaii jjeffcaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csynineyang
Copy link
Contributor Author

【done】1、非命中shadow rule,非命中sharding rule:穿透到0库建表; 【done】2、非命中shadow rule,命中sharding rule:建分区表; 【todo】3、命中shadow rule,非命中sharding rule:穿透到0库建影子表; 【todo】4、命中shadow rule,命中sharding rule:建影子分区表;

另外,建表语句还需完善,暂时别合入,: )

1、shadow非核心功能,暂时忽略;
2、建表支持IfNotExists语句;

求review~~

@dongzl dongzl changed the title [WIP]Support create table SQL statement (#424) Support create table SQL statement (#424) Apr 16, 2023
@Mulavar
Copy link
Contributor

Mulavar commented Apr 17, 2023

maybe we should squash the commits or just open a new pr to make the commit message cleaner? It's 25 commits now and there's much commit history about 'merge'.

Copy link
Contributor

@maronghe maronghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you unify the same capitalization of error messages in the project?

pkg/runtime/ast/create_table.go Outdated Show resolved Hide resolved
Copy link
Contributor

@maronghe maronghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongzl
Copy link
Contributor

dongzl commented Apr 17, 2023

maybe we should squash the commits or just open a new pr to make the commit message cleaner? It's 25 commits now and there's much commit history about 'merge'.

Hi @Mulavar , we use Squash and merge for the PR.

@AlexStocks AlexStocks merged commit a00866f into arana-db:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants