fix: handle empty query correctly #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeffcaii
requested review from
mengchuang123,
dongzl,
70data,
AlexStocks,
baerwang,
binbin0325,
chuntaojun,
georgehao and
gongna-au
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 36.94% 36.87% -0.08%
==========================================
Files 202 202
Lines 22290 22344 +54
==========================================
+ Hits 8236 8240 +4
- Misses 13137 13187 +50
Partials 917 917
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dongzl
approved these changes
Mar 18, 2023
AlexStocks
approved these changes
Mar 18, 2023
jjeffcaii
force-pushed
the
fix/ISSUE-641
branch
from
5c74314
to
a3806c6
Compare
Mulavar
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Handle empty query correctly, will follow the normal MySQL behavior below:
Which issue(s) this PR fixes:
Fixes #641
Special notes for your reviewer:
Does this PR introduce a user-facing change?: