Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Support MySQL window function. #688

Merged
merged 41 commits into from
Jun 18, 2023
Merged

[SQL] Support MySQL window function. #688

merged 41 commits into from
Jun 18, 2023

Conversation

csynineyang
Copy link
Contributor

@csynineyang csynineyang commented May 21, 2023

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Patch coverage: 58.30% and project coverage change: +0.31 🎉

Comparison is base (e19afc8) 36.02% compared to head (3dd8d97) 36.34%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   36.02%   36.34%   +0.31%     
==========================================
  Files         216      224       +8     
  Lines       23128    23459     +331     
==========================================
+ Hits         8332     8526     +194     
- Misses      13870    13965      +95     
- Partials      926      968      +42     
Impacted Files Coverage Δ
pkg/runtime/function/first_value.go 48.83% <48.83%> (ø)
pkg/runtime/function/last_value.go 50.00% <50.00%> (ø)
pkg/runtime/function/lag.go 56.92% <56.92%> (ø)
pkg/runtime/function/lead.go 56.92% <56.92%> (ø)
pkg/runtime/function/rank.go 65.21% <65.21%> (ø)
pkg/runtime/function/dense_rank.go 68.00% <68.00%> (ø)
pkg/runtime/function/cume_dist.go 70.37% <70.37%> (ø)
pkg/runtime/function/percent_rank.go 70.37% <70.37%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dongzl dongzl added the SQL SQL support label May 24, 2023
@dongzl dongzl added this to the 0.3.0 milestone May 24, 2023
@Mulavar
Copy link
Contributor

Mulavar commented May 24, 2023

Maybe we should add an issue to describe the progress of this work and note some subtasks, it looks like a big feature.

@Mulavar
Copy link
Contributor

Mulavar commented May 24, 2023

Please sqush the commit to rewrod the commit message, it has too much useless commit message like Merge branch 'arana-db:master' into master.

@Mulavar
Copy link
Contributor

Mulavar commented May 24, 2023

Maybe we should add an issue to describe the progress of this work and note some subtasks, it looks like a big feature.
@csynineyang

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexStocks AlexStocks merged commit c696476 into arana-db:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL SQL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants