show table rules #760
show table rules #760
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #760 +/- ##
==========================================
+ Coverage 38.38% 40.33% +1.94%
==========================================
Files 254 265 +11
Lines 26359 26897 +538
==========================================
+ Hits 10119 10849 +730
+ Misses 15121 14881 -240
- Partials 1119 1167 +48
☔ View full report in Codecov by Sentry. |
| proto.NewValueString(strings.Join(columns, ",")), | ||
| proto.NewValueString(""), | ||
| proto.NewValueString(fmt.Sprintf("%s", vs.Table.Computer)), | ||
| proto.NewValueInt64(int64(step)), |
There was a problem hiding this comment.
How about changing step to varchar? I mean, for the columns [{"column":"foo"},{"column":"bar","step":2}], we can return:
| ... | columns | ... | steps |
|---|---|---|---|
| ... | foo,bar | ... | 1,2 |
binbin0325
force-pushed
the
show_table_rules
branch
from
c8ec947
to
36093db
Compare
binbin0325
force-pushed
the
show_table_rules
branch
from
36093db
to
b365ceb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| for _, v := range tests { | ||
| rows, err := db.Query(v.sql) | ||
| defer rows.Close() |
There was a problem hiding this comment.
Use closure instead, never defer in a for-loop directly.
What this PR does:
support
show table rules fromWhich issue(s) this PR fixes:
Fixes #628
Special notes for your reviewer:
Does this PR introduce a user-facing change?: