added functionality for add/delete node(s) #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "host_list":[ | ||
| "xxxx" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Can we indent this file so it is easier to read?
|
eb045a5 has all the changes you asked to be made. Please check when you find time. thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, This tool is very useful for my team, Thank you!. I've added CLI interface for adding/deleting node(s).
bin/jenkinscli node create_new_node -c <path to yaml file with Jenkins credentials>/login.yml --json <path to json file with a list of tmp machines>host-list.jsonjenkinscli node create_new_node -c login.yml --name tmppn0019648001.lab.in --credentials_id e7df46-278c-459d-8cfd-ec93b21a54 --labels test --executors 2login yaml file example config/login.yml.example
tmp host list example : config/host-list.json
could you please review my code and accept the changes? Thanks again!