Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove escape characters from Jenkins response body #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itskingori
Copy link

To fix an issue with the \e character which seems like an issue with JSON.parse so figured this is a simpler solution (we can discuss alternatives i.e. if we should change to Oj ... there).

Closes #294.

@itskingori itskingori force-pushed the fix_jenkins_response_issue branch from 0702743 to 371b721 Compare June 3, 2022 08:53
@zacblazic zacblazic force-pushed the fix_jenkins_response_issue branch from 371b721 to 202630a Compare March 20, 2023 09:03
@grosser
Copy link
Collaborator

grosser commented Mar 20, 2023

please add a test too
do you have an example string ... and does oj parse that correctly ?

@grosser
Copy link
Collaborator

grosser commented Mar 20, 2023

ah yes, saw the example ... just put that into a test and this should be goo to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse response body with bad characters
2 participants