Skip to content

Commit

Permalink
re-enabled optimizeTopK test assertions (#543)
Browse files Browse the repository at this point in the history
  • Loading branch information
rashtao committed Mar 22, 2024
1 parent bfd92c0 commit d65a222
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 12 deletions.
5 changes: 2 additions & 3 deletions driver/src/test/java/com/arangodb/ArangoSearchAsyncTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,8 @@ void arangoSearchOptions(ArangoDatabaseAsync db) throws ExecutionException, Inte
assertThat(nested.getName()).isEqualTo("f2");
}

if (isEnterprise() && isAtLeastVersion(3, 11)) {
// FIXME: BTS-1428
// assertThat(properties.getOptimizeTopK()).containsExactly(optimizeTopK);
if (isEnterprise() && isAtLeastVersion(3, 12)) {
assertThat(properties.getOptimizeTopK()).containsExactly(optimizeTopK);
}

}
Expand Down
5 changes: 2 additions & 3 deletions driver/src/test/java/com/arangodb/ArangoSearchTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -715,9 +715,8 @@ void arangoSearchOptions(ArangoDatabase db) {
assertThat(nested.getName()).isEqualTo("f2");
}

if (isEnterprise() && isAtLeastVersion(3, 11)) {
// FIXME: BTS-1428
// assertThat(properties.getOptimizeTopK()).containsExactly(optimizeTopK);
if (isEnterprise() && isAtLeastVersion(3, 12)) {
assertThat(properties.getOptimizeTopK()).containsExactly(optimizeTopK);
}

}
Expand Down
5 changes: 2 additions & 3 deletions driver/src/test/java/com/arangodb/InvertedIndexAsyncTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,8 @@ private void assertCorrectIndexEntity(InvertedIndexEntity indexResult, InvertedI
assertThat(indexResult.getCache()).isEqualTo(options.getCache());
assertThat(indexResult.getPrimaryKeyCache()).isEqualTo(options.getPrimaryKeyCache());

if (isEnterprise() && isAtLeastVersion(3, 11)) {
// FIXME: BTS-1428
// assertThat(indexResult.getOptimizeTopK()).containsExactlyElementsOf(options.getOptimizeTopK());
if (isEnterprise() && isAtLeastVersion(3, 12)) {
assertThat(indexResult.getOptimizeTopK()).containsExactlyElementsOf(options.getOptimizeTopK());
}
}

Expand Down
5 changes: 2 additions & 3 deletions driver/src/test/java/com/arangodb/InvertedIndexTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,8 @@ private void assertCorrectIndexEntity(InvertedIndexEntity indexResult, InvertedI
assertThat(indexResult.getCache()).isEqualTo(options.getCache());
assertThat(indexResult.getPrimaryKeyCache()).isEqualTo(options.getPrimaryKeyCache());

if (isEnterprise() && isAtLeastVersion(3, 11)) {
// FIXME: BTS-1428
// assertThat(indexResult.getOptimizeTopK()).containsExactlyElementsOf(options.getOptimizeTopK());
if (isEnterprise() && isAtLeastVersion(3, 12)) {
assertThat(indexResult.getOptimizeTopK()).containsExactlyElementsOf(options.getOptimizeTopK());
}
}

Expand Down

0 comments on commit d65a222

Please sign in to comment.