Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Add documentation about options used in database creation #243

Merged
merged 5 commits into from
Dec 2, 2019

Conversation

ObiWahn
Copy link
Contributor

@ObiWahn ObiWahn commented Nov 25, 2019

No description provided.

Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would help to add a further description to the "sharding" attribute. What does "single" actually mean? Additionally, it is probably not intuitively clear what the "minimum replication factor" is without further description.
If you could add an explanatory sentence to these options it would be cool. Thanks!

The *options* attribute can be used to set defaults for collections that will
be created in the new database:

* *sharding*: The sharding method to use. Valid values are: "" or "single
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* *sharding*: The sharding method to use. Valid values are: "" or "single
* *sharding*: The sharding method to use. Valid values are: "" or "single".

@ObiWahn
Copy link
Contributor Author

ObiWahn commented Nov 25, 2019

The descriptions of options should really be in a single place. Is there some plan to remove the split of the documentation?

@jsteemann
Copy link
Contributor

I agree. @Simran-B : are there any changes planned for cleaning up the documentation "mess", i.e. removing the need to adjust two repositories when docs are adjusted?

* *replicationFactor*: Default replication factor. Special values include "satellite",
which will replicate the collection to every DB-server, and 1, which disables replication.
* *minReplicationFactor*: Default minimum replication factor.
* *minReplicationFactor*: Default minimum replication factor. Collections with
a lower replication factor than this value can not be created in the new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not what this attribute is doing.
Can you check other occurrences of "minReplicationFactor" in the docs or changelog or new features to see what it does exactly?

@Simran-B
Copy link
Collaborator

are there any changes planned for cleaning up the documentation "mess", i.e. removing the need to adjust two repositories when docs are adjusted?

@jsteemann Do you refer to the DocuBlock being in the main repo and the rest being here? Well, I discussed this with Jörg last week and we do want to put everything into the docs repo. This isn't an easy task however, and we may do additional refactoring as part of a larger project soon.

@Simran-B Simran-B merged commit 5ff4726 into master Dec 2, 2019
@Simran-B Simran-B deleted the db-options branch December 2, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants