Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the connection when the initial onCreatedCallback fails #113

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Apr 24, 2018

The test showed that an authenticated VST test run fails on the very first connection only.
This very first test creates a connection where the authentication callback fails.
When that fails, the connection was still left "usable", which caused the failures.

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit a7d74cb into master Apr 24, 2018
@ewoutp ewoutp deleted the fix-vst-fail-on-created-cb branch April 24, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants