Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent possible endless read chunk look in in VST connection #125

Merged
merged 2 commits into from
May 28, 2018
Merged

Prevent possible endless read chunk look in in VST connection #125

merged 2 commits into from
May 28, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented May 22, 2018 •
edited
Loading

This PR break the read chunk loop of a VST connection when it encounters to many errors in succession.
It also adds a few safety checks.

@ewoutp ewoutp requested a review from graetzer May 22, 2018 13:00
graetzer
graetzer approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@graetzer graetzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 252c62d into master May 28, 2018
@ewoutp ewoutp deleted the bugfix/prevent-endless-vst-readloop branch May 28, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graetzer graetzer graetzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @graetzer