Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NoDeduplicate field for hash & skiplist index options #49

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jul 6, 2017

Fixes #48

The added field is NoDeduplicate and not Deduplicate to avoid breaking changes.
Since the default value for deduplicate is true, and the go field will default to false if left unspecified, you would get unexpected deduplicate=false behavior when just updating the go driver without updating your code.

See also arangodb/arangodb#2644

@ewoutp ewoutp self-assigned this Jul 6, 2017
@ewoutp ewoutp merged commit 0570a13 into master Jul 6, 2017
@ewoutp ewoutp deleted the feature/deduplicate-attr branch July 6, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant