Documented behavior for custom http.Transport wrt MaxIdleConnsPerHost field #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
reviewed
Feb 9, 2018
| // When using a custom `http.Transport`, make sure to set the `MaxIdleConnsPerHost` field at least as | ||
| // high as the maximum number of concurrent requests you will make to your database. | ||
| // A lower number will cause the golang runtime to create additional connections and close them | ||
| // directly after use, resulting in a large number of connections in `TIME_WAIT` state. |
There was a problem hiding this comment.
We should add a comment here that we set the default to at least 64 and that one should lower it if needed.
There was a problem hiding this comment.
Added a line in master
| httpTransport.MaxIdleConnsPerHost = DefaultMaxIdleConnsPerHost | ||
| } | ||
| defaultMaxIdleConns := 3 * DefaultMaxIdleConnsPerHost | ||
| if httpTransport.MaxIdleConns > 0 && httpTransport.MaxIdleConns < defaultMaxIdleConns { |
There was a problem hiding this comment.
It seems MaxIdleConnsPerHost is set to 0 here if nothing is set, is the same true for MaxIdleConns? If so, then we should write "== 0" here, otherwise we do not set out default if the user has not given anything.
There was a problem hiding this comment.
Behavior for MaxIdleConns==0 is different. It means "unlimited"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info came from https://groups.google.com/forum/#!topic/golang-nuts/WjFjmtqg3kA