Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test framework #11

Merged
merged 23 commits into from
Feb 26, 2018
Merged

Test framework #11

merged 23 commits into from
Feb 26, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Feb 20, 2018

This PR adds a test framework to the project.
The concept is as follows:

  • Run make run-tests
  • It builds a test binary & docker image
  • It creates a new namespace (in k8s)
  • It deploys the operator in that namespace
  • It executes kubectl run .. to run the test docker image

Output looks like:

$ make run-tests
docker build --quiet -f Dockerfile.test -t arangodb/arangodb-operator-test .
sha256:e3a2f09bd21279e69c4f10138442ecb171bd0810875019df284209e172e46802
/Users/ewout/arangodb/k8s-operator/scripts/kube_delete_namespace.sh arangodb-operator-tests
namespace "arangodb-operator-tests" deleted
kubectl create namespace arangodb-operator-tests
namespace "arangodb-operator-tests" created
kubectl --namespace=arangodb-operator-tests create -f examples/deployment.yaml
deployment "arangodb-operator" created
kubectl --namespace arangodb-operator-tests run arangodb-operator-test -i --rm --quiet --restart=Never --image=arangodb/arangodb-operator-test --env="TEST_NAMESPACE=arangodb-operator-tests" -- -test.v
--- PASS: TestSimpleSingle (4.58s)
PASS
kubectl delete namespace arangodb-operator-tests --ignore-not-found --now
namespace "arangodb-operator-tests" deleted

@ewoutp
Creating test framework
5a7597d
@ewoutp
Implemented first test
ad50694
@ewoutp
Allow for TESTNAMESPACE to be set outside the makefile
3e082c5
@ewoutp
Added Jenkinsfile
8a0765f
@ewoutp
Fix test stage
b9fc6db
@ewoutp
Fix string encoding wrt TESTNAMESPACE
56fd9ee
@ewoutp
Fail on missing namespace argument
f921584
@ewoutp
Better testin on jenkins
69554d5
@ewoutp
Customize namespace from git commit
cf5c5b5
@ewoutp
Use default namespace that is short to avoid exceeding 63 char limit
29cd0e3
@ewoutp
Setup role based access control support
91a6abe
@ewoutp
Use shorter git commit hash to avoid namespace length issues
b234c27
@ewoutp
Fix groovy syntax
12b4adb
@ewoutp
Abandon shot git hashes
aa695ff
@ewoutp
Added go-driver to dependencies
a73628d
@ewoutp
Added CreateArangodClient helper
f356d42
@ewoutp
Fixed endpoint
c04d3c8
@ewoutp
Merge branch 'master' into test-framework
90f900b
@ewoutp
Merge branch 'master' into test-framework
b66f581
@ewoutp
Merge branch 'master' into test-framework
77bf206
@ewoutp
Merge branch 'master' into test-framework
08dfddd
@ewoutp
Added configurable KUBECONFIG
8d39929
@ewoutp
Fix groovy
8bbebc8
ObiWahn
ObiWahn approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@ObiWahn ObiWahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proposed changes for shell scripts:
https://github.com/arangodb/k8s-operator/tree/test-framework-shell

pkg/deployment/secrets.go
@@ -36,30 +38,24 @@ func (d *Deployment) getJWTSecret(apiObject *api.ArangoDeployment) (string, erro
}
kubecli := d.deps.KubeCli
secretName := apiObject.Spec.Authentication.JWTSecretName
s, err := kubecli.CoreV1().Secrets(apiObject.GetNamespace()).Get(secretName, metav1.GetOptions{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that the version gets further abstracted away!

pkg/util/k8sutil/secrets.go
import (
"fmt"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want meta or metav1 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metav1 is used all over the place.

@ewoutp ewoutp merged commit b96da3b into master Feb 26, 2018
@ewoutp ewoutp deleted the test-framework branch February 26, 2018 10:33
@ghost ghost mentioned this pull request Apr 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ObiWahn ObiWahn ObiWahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @ObiWahn