Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT-402 Fix for ArangoTask list error #1289

Merged
merged 5 commits into from
Apr 17, 2023
Merged

GT-402 Fix for ArangoTask list error #1289

merged 5 commits into from
Apr 17, 2023

Conversation

jwierzbo
Copy link
Collaborator

No description provided.

@jwierzbo jwierzbo requested a review from a team April 12, 2023 11:20
@cla-bot cla-bot bot added the cla-signed label Apr 12, 2023
informalict
informalict approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@informalict informalict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jwierzbo jwierzbo force-pushed the GT-402_fix_arangotask branch from aa57b4f to bb4e8b4 Compare April 12, 2023 16:01
ajanikow
ajanikow requested changes Apr 14, 2023
View reviewed changes
chart/kube-arangodb/crds/database-task.yaml Outdated
@@ -9,8 +9,7 @@ spec:
listKind: ArangoTaskList
plural: arangotasks
shortNames:
- arangodb
- arango
- arangotask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

@fullc0de
Copy link

Hello @jwierzbo

Is this change also related to the following error message I ran into my k8s monitoring?
E0417 01:26:56.058194 1 reflector.go:138] pkg/generated/informers/externalversions/factory.go:125: Failed to watch *v1.ArangoTask: failed to list *v1.ArangoTask: the server could not find the requested resource (get arangotasks.database.arangodb.com)

Thank you!

@ajanikow
Copy link
Collaborator

Hello @jwierzbo

Is this change also related to the following error message I ran into my k8s monitoring? E0417 01:26:56.058194 1 reflector.go:138] pkg/generated/informers/externalversions/factory.go:125: Failed to watch *v1.ArangoTask: failed to list *v1.ArangoTask: the server could not find the requested resource (get arangotasks.database.arangodb.com)

Thank you!

Yes, it wil fix this misleading error message.

@ajanikow ajanikow closed this Apr 17, 2023
@ajanikow ajanikow reopened this Apr 17, 2023
@ajanikow ajanikow merged commit 1c3ba8b into master Apr 17, 2023
@ajanikow ajanikow deleted the GT-402_fix_arangotask branch April 17, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@informalict informalict informalict approved these changes

@ajanikow ajanikow ajanikow approved these changes

@nikita-vanyasin nikita-vanyasin nikita-vanyasin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwierzbo @fullc0de @ajanikow @nikita-vanyasin @informalict