[Feature] Abort resignation of leadership when dbserver restarted #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
informalict
force-pushed
the
GT-354/abort-resignation-leadership
branch
from
9bce272 to
ce3de44
Compare
informalict
changed the title
ajanikow
force-pushed
the
GT-354/abort-resignation-leadership
branch
from
9eb192e to
a184177
Compare
ajanikow
changed the title
jwierzbo
approved these changes
Jul 20, 2023
ajanikow
force-pushed
the
GT-354/abort-resignation-leadership
branch
from
d948daa to
cdff231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no automated tests for it. I did some manual tests where I restarted DB server when it was in restarting phase, so operator was able to log information about this fact.
When leader's shards must be moved from one DB server to another, then resign leadership action must be performed.
Operator requests for it and checks progress. In the meantime, it may occur that DB server is restarted and action will not be finished in some timeout ~1 hour. With this PR, this action will be removed immediately whenever it occurs.