Cleanup long terminating stateful pods #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gfix/cleanup-long-terminating-stateful-pods
matthewvon
reviewed
Jun 5, 2018
| // Member is (still) found, skip it | ||
| if m.Conditions.Update(api.ConditionTypeMemberOfCluster, true, "", "") { | ||
| list.Update(m) | ||
| if err := r.context.UpdateStatus(status); err != nil { |
There was a problem hiding this comment.
If this fails on one server, would that lead to subsequent server in the ForeachServerGroup not getting their last access time updated ... maybe leading to false delete?
There was a problem hiding this comment.
Yes, other member can be affected.
It would mean that other members may late with recording their "I'm a member of the cluster" state. If anything, they will be removed later, not earlier.
matthewvon
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #151
This PR adds cleaning up of members (and their Pods & PVCs) that are no longer part of a cluster.
When
/_admin/cluster/healthno longer shows the member ID, it is subject to removal.To do this, a new condition is added for members that records if the member was at least once reported as member of the cluster. Without this, the member could be deleted before it even has a chance to join the cluster.