Operator high-availability #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewvon
reviewed
Jun 5, 2018
| @@ -5,7 +5,7 @@ metadata: | |||
| name: {{ .DeploymentReplication.OperatorDeploymentName }} | |||
| namespace: {{ .DeploymentReplication.Operator.Namespace }} | |||
| spec: | |||
| replicas: 1 | |||
| replicas: 2 | |||
There was a problem hiding this comment.
So 1 can fail. Could be 3, but IMO 2 would make a good default (note that this deployment can be fully customized by customer if they want to)
matthewvon
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the number of replicas for the all operator to 2 (from 1). This ensures that 1 replica is always standing by (waiting in leader election) and able to take over quickly when the leader is not responding.
This is faster than waiting for kubernetes to terminate a pod that becomes unresponsive.
This PR also adds tolerations that were still missing on the deployment-replication operator.