Force volumes to unique nodes for production environments #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewvon
approved these changes
Jun 7, 2018
| // createNodeClientMap creates a map from node name to API. | ||
| // Clients that do not respond properly on a GetNodeInfo request are | ||
| // ignored. | ||
| func createNodeClientMap(ctx context.Context, clients []provisioner.API) map[string]provisioner.API { |
There was a problem hiding this comment.
should I be harassing you about these functions being nicely isolated and yet have no unit tests to demonstrate they work?
There was a problem hiding this comment.
Yes .... will need to make some mocks to do so.
Will do so in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that PersistentVolume's are created such that PVC's for the same deployment name & role are never created on the same node (in case of production environment)