Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow override the name of the operator #1737

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rob-64
Copy link

@rob-64 rob-64 commented Oct 14, 2024

Allow custom naming of the operator.

Right now when I do a helm install called "arango-operator" it forces the name to be "arango-arango-operator-operator"

I would like to be able to name the helm release nicely and have a matching pod name.

@rob-64 rob-64 requested a review from a team as a code owner October 14, 2024 15:00
Copy link

cla-bot bot commented Oct 14, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rob Theriault.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Oct 15, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

@ajanikow
Copy link
Collaborator

Hello @rob-64 !

Is it possible to sign CLA?

Ref: https://arangodb.com/community/#contribute

Otherwise, we can add those changes ourselves (if you will be able to create an issue)

Best,
Adam.

@rob-64
Copy link
Author

rob-64 commented Oct 28, 2024

Just emailed the CLA @ajanikow

Copy link

cla-bot bot commented Nov 4, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

Copy link

cla-bot bot commented Nov 4, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

Copy link

cla-bot bot commented Nov 7, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

Copy link

cla-bot bot commented Nov 7, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

Copy link

cla-bot bot commented Nov 14, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

@ajanikow
Copy link
Collaborator

Hello!

Can we rewrite this change into our doc fixes?

This NDA seems to be a blocker for merge.

Best Regards,
Adam.

@rob-64
Copy link
Author

rob-64 commented Nov 19, 2024

Hello!

Can we rewrite this change into our doc fixes?

This NDA seems to be a blocker for merge.

Best Regards, Adam.

Yes. If you can just take the changes that would be great.

I emailed the CLA weeks ago . I'm not sure what the issue is

@fceller
Copy link
Collaborator

fceller commented Nov 20, 2024

@rob-64 @ajanikow @jwierzbo CLA received

Copy link

cla-bot bot commented Nov 20, 2024

Fresh avocado detected! Welcome and thank you for your contribution @rob-64. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask cla(at)arangodb.com if you have issues.

@cla-bot cla-bot bot removed the cla-signed label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants