Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved readiness probe, database services only use ready pods #176

Merged
merged 4 commits into from
Jun 14, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 14, 2018

This PR changes the readiness tests of some pods & tweaks the services used to access the database.

  • The readiness probe is now added to all single & coordinator pods (before only coordinator)
  • The readiness probe is done a lot quicker and more often
  • The readiness probe is done on _admin/echo for activefailover deployments
  • The database & external access services no only accept ready endpoints

As a result, activefailover deployments only expose the master single server.
Also a cluster deployment exposes only ready coordinators.

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit e631b5c into master Jun 14, 2018
@ewoutp ewoutp deleted the bugfix/service-endpoints branch June 14, 2018 15:00
@ewoutp ewoutp removed the 4 - Review label Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants