[Feature] [Platform] Storage Debug

[ajanikow]

No description provided.

[Copilot]

Pull Request Overview

This PR adds a debug‐package extension for the shutdown integration that collects local debug files and sends them to the Storage V2 service, updates context and shutdown handling to support cancellation hooks, and introduces a SendFile helper for streaming files.

• Added a ContextKey type and shutdown‐cancel context helpers
• Implemented the Debug shutdown extension (ExtensionShutdownV1Debug) and wired it into shutdown and profile generation
• Introduced SendFile in Storage V2 helpers and updated CLI/docs for new debug flags

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/util/context.go	Added ContextKey type for context‐value keys
pkg/util/closer/close.go	Fixed mutex usage in closeOnce.Close()
pkg/integrations/suite.go	Introduced WithShutdownV1ContextCancelFunc/extractShutdownFunc
pkg/integrations/sidecar/extension.shutdown.v1.debug.go	New debug extension for shutdown
pkg/integrations/shutdown_v1.go	Plumbed debug config, flags, and handler changes
pkg/integrations/register.go	Integrated shutdown debug into service registration
pkg/deployment/resources/arango_profiles.go	Extended profile labels function to accept additional KV pairs
integrations/storage/v2/definition/helpers.go	Added SendFile helper for streaming local files
docs/	Updated CLI flags and examples for shutdown debug
cmd/	Switched various Execute() calls to ExecuteContext(shutdown.Context())

Comments suppressed due to low confidence (2)

pkg/util/context.go:122

• [nitpick] The new ContextKey type lacks a doc comment. Adding a brief comment explaining its intended use and conventions will improve readability and maintainability.

type ContextKey string

docs/integration-sidecar.md:104

• [nitpick] The example label key storage.integration.profiles.arangodb.com/debug may not match the code-generated key from NewProfileIntegrationFeature. Please verify that the docs and the actual label format are aligned.

    storage.integration.profiles.arangodb.com/debug: "enabled"

[Copilot]

When labels is nil, the function returns nil and ignores any additional entries. Consider initializing the output map unconditionally so that additional key/value pairs are respected even if the base labels map is empty.

Suggested change

	if labels == nil {
	return nil
	}
	out := make(map[string]string)
	for k, v := range labels {
	out[k] = v
	out := make(map[string]string)
	if labels != nil {
	for k, v := range labels {
	out[k] = v
	}

[Copilot]

The explicit f.Close() in the error block combined with the deferred f.Close() causes a redundant file close. Consider removing the manual close and relying on the defer, or otherwise consolidating close logic to avoid double-close scenarios.

Suggested change

	if cerr := f.Close(); cerr != nil {
	return nil, cerr
	}