Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate server on changed arguments #206

Merged
merged 7 commits into from
Jun 29, 2018
Merged

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 28, 2018

This PR adds reconciliation actions that rotates a server, when the commandline argument that is should have are different from what is has right now.

TODO:

  • Add integration test(s)

fixes #189

@ghost ghost assigned ewoutp Jun 28, 2018
@ghost ghost added the 2 - Working label Jun 28, 2018
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 86f5e46 into master Jun 29, 2018
@ghost ghost removed the 4 - Review label Jun 29, 2018
@ewoutp ewoutp deleted the feature/rotate-on-args-change branch June 29, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotate server when cmdline arguments change
2 participants