Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying defaults after immutable fields have been reset #232

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Aug 7, 2018

This PR fixes a problem where a mode field was not reset, because the validation of the spec after applying ResetImmutableFields failed.

@ghost ghost assigned ewoutp Aug 7, 2018
@ghost ghost added the 2 - Working label Aug 7, 2018
@ewoutp ewoutp merged commit 6e960fe into master Aug 7, 2018
@ghost ghost removed the 2 - Working label Aug 7, 2018
@ewoutp ewoutp deleted the bugfix/immutable-field-fix branch August 7, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant