Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom resource spec for ArangoDB Storage operator. #30

Merged
merged 4 commits into from
Mar 6, 2018
Merged

Added custom resource spec for ArangoDB Storage operator. #30

merged 4 commits into from
Mar 6, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 2, 2018

No description provided.

neunhoef
neunhoef approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Where are sizes configured? Or default sizes or anything? Does one specify the needed size with the ArangoDB custom resource? How is negotiated how large the volume in the end actually is. How about resizing?

docs/user/storage_resource.md Outdated
### `spec.storageClass.name: string`

This setting specifies the name of the storage class that
creates `PersistentVolume` will use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ewoutp ewoutp merged commit c0a2b2e into master Mar 6, 2018
@ewoutp ewoutp deleted the local-storage-resource branch March 6, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef