Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS support #43

Merged
merged 12 commits into from
Mar 12, 2018
Merged

TLS support #43

merged 12 commits into from
Mar 12, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 12, 2018

This PR implements support for TLS on the arangod servers.

@ewoutp ewoutp requested a review from neunhoef March 12, 2018 09:29
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found some commented out code, still needed?

optionPair{"--ssl.keyfile", keyPath},
optionPair{"--ssl.ecdh-curve", ""}, // This way arangod accepts curves other than P256 as well.
)
/*if bsCfg.SslKeyFile != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is about client certificate authentication support, which is not in the scope of this PR

@ewoutp ewoutp merged commit 6c3688a into master Mar 12, 2018
@ewoutp ewoutp deleted the tls branch March 12, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants