Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added release code #45

Merged
merged 3 commits into from
Mar 13, 2018
Merged

Added release code #45

merged 3 commits into from
Mar 13, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 12, 2018

This PR extends from #44

It adds the script to make releases.

Note. This is UNTESTED and the only way to test it is to create a release.
So let's review it first

neunhoef
neunhoef reviewed Mar 13, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see this LGTM. What I did not get: What is a release anyway? Are there any artifacts other than a Docker image? Documentation?

@ewoutp ewoutp merged commit bc94a20 into master Mar 13, 2018
@ewoutp ewoutp deleted the releasing branch March 13, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef