Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation support for members. #49

Merged
merged 22 commits into from
Mar 23, 2018
Merged

Rotation support for members. #49

merged 22 commits into from
Mar 23, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 15, 2018 •
edited
Loading

This PR adds:

  • Rotation of those members that are "not up to date according to the current spec" (with exception of image). Note, by far not all settings are checked yet. Will improve in other PR's
  • Upgrading of members that have a different image (provided version change is allowed). When upgrading the member is run once with --database.auto-upgrade.
  • Execution of plan is implemented through Action objects, tailored for a single specific action. Helps to group the code.

@ewoutp ewoutp added the 9 WIP label Mar 15, 2018
kvahed
kvahed approved these changes Mar 23, 2018
View reviewed changes
Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking one of these days you'll put an error in.
Compilation without warnings. Cannot find errors.
LGTM

@ewoutp ewoutp merged commit 8b01a8a into master Mar 23, 2018
@ewoutp ewoutp deleted the rotation branch March 23, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

Assignees
No one assigned
Labels
9 Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @kvahed