Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add tests for immutable cluster parameters #59

Merged
merged 15 commits into from
Mar 27, 2018

Conversation

kvahed
Copy link
Contributor

@kvahed kvahed commented Mar 20, 2018

Added test for immutable fields.
Rest is to follow in later, derived PR.

Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Add file header
Then merge when jenkins is happy

@@ -0,0 +1,73 @@
package tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add file header

Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master needs to be merged in, currently this code won't compile

@ewoutp ewoutp added the 9 WIP label Mar 26, 2018
@ewoutp ewoutp merged commit 9cd6bd1 into master Mar 27, 2018
@ewoutp ewoutp deleted the feature/add-tests-for-immutable-cluster-parameters branch March 27, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants