Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed immitable mode field. #66

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Fixed immitable mode field. #66

merged 1 commit into from
Mar 22, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 22, 2018 •
edited
Loading

It failed because the validation was done to soon, which in resulted in the reset logic being skipped.

Now the early validation is only done for completely new deployments.
For existing deployments, the validation is done in the deployment package.

@ewoutp ewoutp requested a review from kvahed March 22, 2018 14:07
kvahed
kvahed approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ewoutp ewoutp merged commit 5c43746 into master Mar 22, 2018
@ewoutp ewoutp deleted the fix-immutable-mode branch March 22, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

Assignees
No one assigned
Labels
9 Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @kvahed