Deployment state -> phase #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
approved these changes
Mar 27, 2018
| if err := d.resources.EnsureServices(); err != nil { | ||
| d.failOnError(err, "Failed to create services") | ||
| return | ||
| d.CreateEvent(k8sutil.NewErrorEvent("Failed to create services", err, d.GetAPIObject())) |
There was a problem hiding this comment.
Does d.CreateEvent somehow leave this function early (maybe with a panic)? If not, is it right to simply move on, for example if the services have not been setup, should we go on to pods?
There was a problem hiding this comment.
CreateEvent just comes back.
The inspection loop will keep trying to create all resources, so if something fails here, we just keep trying later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the
Statefield inDeploymentStatustoPhaseand greatly reduced the number of phases.The Phase is intended to indicate where in the lifetime a deployment is.
All other state related indicators are now communicated using conditions.
Furthermore, this PR prevents a deployment from going into a Failed phase (from which there is no recover possible) where-ever possible.