Pod monitoring #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
approved these changes
Feb 26, 2018
| return true | ||
| } | ||
|
|
||
| // Remove the condition with given type. |
There was a problem hiding this comment.
// Remove first condition of given type.
There was a problem hiding this comment.
I leave it as is, since the Update function ensures that there is only 1 condition of a given type at all times.
| @@ -99,6 +195,17 @@ func (l MemberStatusList) ContainsID(id string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // ElementByPodName returns the element in the given list that has the given pod name and true. | |||
There was a problem hiding this comment.
searches for first MemberStatus whose name matches a given string. If such a status it found a (status, true) is returned, otherwise (MemberStatus{},false) is returned.
There was a problem hiding this comment.
Changed text a bit different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds monitoring of pods with: