asyncio support

[wshayes]

Hi Joohwan,

We really like your arango library. I am curious what your plans are in regards to asyncio support. I saw you started another repo for it. I'd be interested in helping out where I could to move this forward.

Thanks!

[joowani]

Hi @wshayes,

Thank you for liking python-arango. I am glad to hear that people are finding it useful.

Unfortunately I am too busy right now to start a new project and my knowledge on asyncio (and async programming in general) is novice at best. I'm not sure when I will have time to invest in it. I will keep this issue open for any updates in the future.

Best,
Joohwan

[paulhoule]

I was about to put this request in when I found it was already in.

I thought about it a bit and here is what I know.

Most of the API would not have to change, in particular, you wouldn't have to make every def an async def. That is because you can make it so that in "async mode" the ordinary functions return a coroutine that returns the result instead of returning a result. Somebody can await that result in async code and it will be all good.

The first step is making an HttpClient that uses aiohttp instead of requests; that should be easy, and the key is that we return a coroutine that returns the result.

Another thing that needs to change are the Executors; I think we need to build a parallel set of
executors for the four different implementations of executor.

Then there is the plumbing to make sure that when you using the async HttpClient you also get
the async executors. Then I think we would be in good shape.

The main annoyance I see is that the async/await syntax is Python 3.5+ only. I think the clean solution is make an interface for the sync/asyncio implementations and then have a second package which
is Py3.5 that contains the asyncio implementation.

I might work up the motivation to make a pull request.

[mooncake4132]

This will also be a very useful feature for me. @joowani, is this still something you plan to invest time in?

[bloodbare]

Hi!

I was on the need of an async driver for arangodb so I took yours @joowani and did a fork on async style! Feel free to comment it.

https://github.com/bloodbare/aioarangodb

Thanks for your amazing work, its been so easy to adapt to async world

[joowani]

Hi @bloodbare,

Wow this is amazing! I'll make sure to mention your project in python-arango readme. You should also send an email to ArangoDB team so they can have your driver on their website. Awesome work.

[rennenc]

@bloodbare's package looks amazing!

Is there still a plan to support async io in the formal package?
Seems like this repo keeps updating every few months while the asyncio's last commit is from 1y ago and less popular.

[alekseitylindus]

Hi!

I was also looking for the asynchronous version and noticed that the version from @bloodbare had not been updated for over a year, so I made a fork (not a copy) and made it fully asynchronous. The current version (1.0.0) fully complient to python-arango 7.2.0.

https://github.com/mirrorrim/aioarango

@rennenc please take a look, I'll try to keep it up to date :)

[rennenc]

Thanks. I still think it would be great to have to adopted and maintained as part of the same repo.
Nevertheless, will take a look.

[bloodbare]

Hey I have no problem to keep it on my repo, I've not been updating because we did not had the need, PRs are more than welcome. R Missatge de Rennen ***@***.***> del dia dl., 5 de jul. 2021 a les 15:18:

…

Thanks. I still think it would be great to have to adopted and maintained as part of the same repo. Nevertheless, will take a look. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADW4AKUW6UCNE4JEAJVJMTTWGWMDANCNFSM4GZY6DFA> .

-- Ramon a.k.a bloodbare

[alekseitylindus]

Sorry, I didn't see any activity in your repository: 4 open issues and 1 pull request :(

[bloodbare]

I see .. the PR notification where lost. I'll update it thanks for the ping! Missatge de mirrorrim ***@***.***> del dia dl., 5 de jul. 2021 a les 17:09:

…

Sorry, I didn't see any activity in your repository: 4 open issues and 1 pull request :( — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADW4APGHJBXR3ESJ6Q3MS3TWHDL5ANCNFSM4GZY6DFA> .

-- Ramon a.k.a bloodbare

[alexvanzyl]

First thanks @joowani for all the efforts on the python-arango library it's really a well-written project.

I was looking for an async solution and judging from the comments it seems like having an async version of this library will be beneficial. I see @mirrorrim and @bloodbare has already done some work to make this possible.

@mirrorrim or @bloodbare have you reached out or would you consider making either of your repositories part of the ArangoDB Community?

I think it would be cool to have this part of an official community package just to get more eyes on it and would be happy to contribute in terms of keeping it up to date with the python-arango package. Also would like to avoid creating another fork if possible.