Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "cancelled" response #364

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Removing "cancelled" response #364

merged 2 commits into from
Feb 28, 2025

Conversation

apetenchea
Copy link
Member

The documentation incorrectly states that the status() of an AsyncJob could have the value "cancelled". If you look at the implementation, the method may only return "pending" or "done". In all other cases, it raises an error.

Hence, we should not mention it.

@apetenchea apetenchea self-assigned this Feb 25, 2025
@apetenchea apetenchea requested a review from aMahanna February 25, 2025 05:57
@apetenchea apetenchea merged commit 33e09e1 into main Feb 28, 2025
37 checks passed
@apetenchea apetenchea deleted the chore/no-cancelled-option branch February 28, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants