Feature/vpack sorting test #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dothebart
reviewed
Sep 17, 2024
| // Insert test data: | ||
| progress('802: inserting test data'); | ||
| db._query(aql` | ||
| INSERT { _key: "1", value: [1152921504606846976, "z"] } INTO ${c} |
There was a problem hiding this comment.
please add loopcount in another attribute
dothebart
approved these changes
Sep 17, 2024
7 tasks
dothebart
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR adds a test for validating VPack numerical sorting in ArangoDB, specifically addressing sorting behavior for large numeric values across different versions.
Problem
Large numeric values were previously cast to doubles for comparison, leading to incorrect sorting and potential data corruption in RocksDB. The issue is fixed in versions 3.12.2 and 3.11.11, introducing a new comparator that requires migration for proper sorting.
Test Script
Insert Test Data: Add documents with large numeric values to test collections.
Initial Sorting Check:
Versions < 3.11.11 and < 3.12.2: Verify incorrect sorting (z, x, y).
Versions >= 3.11.11 and >= 3.12.2: Verify correct sorting (y, z, x).
Upgrade & Migration: Upgrade ArangoDB, run the migration, and verify sorting changes.
Final Check: Ensure correct sorting and data integrity after migration.
Checklist