cancel request when abort / timeout / error + proper tests for abortion #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 99.55% 99.12% -0.44%
==========================================
Files 6 6
Lines 452 457 +5
Branches 147 146 -1
==========================================
+ Hits 450 453 +3
- Misses 1 2 +1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
arantes555
force-pushed
the
fix-abort-request
branch
from
d7188a9
to
4471d8a
Compare
achingbrain
added a commit
to ipfs/js-ipfs-utils
that referenced
this pull request
Nov 25, 2020
No need to use the fork any more as the original bug has been [fixed](arantes555/electron-fetch#31). The js-IPFS build passes with this change: ipfs/js-ipfs#3414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.